BUG FIX #538 #760
BUG FIX #538 #760
Conversation
Signed-off-by: Krishna babu <[email protected]>
Update links.yml
Krish-2505
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
.github/workflows/links.yml
Outdated
| - name: lychee Link Checker | ||
| id: lychee | ||
| uses: lycheeverse/[email protected] | ||
| with: | ||
| args: --accept=200,403,429 "**/*.html" "**/*.md" "**/*.txt" "**/*.json" --exclude "file:///github/workspace/*" --exclude-mail | ||
| args: --accept=200,403,429 "**/*.html" "**/*.md" "**/*.txt" "**/*.json" --exclude "file:///github/workspace/*" --exclude "file:///home/runner/work/opensearch-py/opensearch-py/docs/source/README.md" --exclude-mail |
There was a problem hiding this comment.
- Can this be a relatie path,
docs/source/README.md? - Lychee supports storing the list of files to exclude in a file, e.g.
.lychee.excludes. Then you can use--exclude-file .lychee.excludeswhich makes this command line shorter. Let's use that.
.github/workflows/links.yml
Outdated
| @@ -14,11 +14,16 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Remove symlink | |||
There was a problem hiding this comment.
What's the purpose of removing the symlink if we're going to exclude it below?
There was a problem hiding this comment.
I tried excluding file(docs/source/readme.md) from link checking, but link checker excluding readme.md in both root and also in docs/source , so I tried removing symlink ,then link checker worked. The exclude below is not for excluding file, there may be a reference to this symlink file in other doc, so to ensure that link checker doesn't validate this reference as it is now-nonexistent soft link. Although it will still work without excluding this.
There was a problem hiding this comment.
Deleting the symlink is definitely a workaround, but not a pretty one. Let's figure out how to do without it, remove it.
You also have file:///home/runner/work/opensearch-py/opensearch-py/docs/source/README.md in .lychee.excludes, so it sounds like you're saying that it doesn't work?
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
simplifying args by using lychee.excludes file Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
.github/workflows/links.yml
Outdated
| @@ -14,11 +14,16 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Remove symlink | |||
There was a problem hiding this comment.
Deleting the symlink is definitely a workaround, but not a pretty one. Let's figure out how to do without it, remove it.
You also have file:///home/runner/work/opensearch-py/opensearch-py/docs/source/README.md in .lychee.excludes, so it sounds like you're saying that it doesn't work?
.github/workflows/.lychee.excludes
Outdated
| @@ -0,0 +1,2 @@ | |||
| file:///github/workspace/* | |||
| file:///home/runner/work/opensearch-py/opensearch-py/docs/source/README.md | |||
There was a problem hiding this comment.
These are pattern matched/regexes, I think it should work without file://, try */github/workspace/* */docs/source/README.md
There was a problem hiding this comment.
Basically removing sym link before link checker is my solution . Excluding (file:///home/runner/work/opensearch-py/opensearch-py/docs/source/README.md ) is needed . Let me give u a example, if u have readme as a relative link in some other doc, link checker will fail, because we removed sym link before link checking started . So to avoid this case I excluded that reference from link checker.so basically it's not about excluding file to be checked in link checker, it's about excluding the reference to be link checked.
There was a problem hiding this comment.
I tried excluding file using --exclude-path and --exclude-file , but it's excluding both readme files. So removing sym link may be the only option. At the end of link checking , I added sym link again so that it won't effect other workflow.
|
I think we both misunderstood how Lychee works. The However this creates a new problem. We deploy these docs to https://opensearch-project.github.io/opensearch-py/ and the links would then be broken on that site. So we would need to symlink the rest of markdown files. I tried that and ran into more problems trying to generate docs with I propose we just get rid of the symlink and remove README.md from docs/source/index.md, then add the relevant content from README.md to it. Then we don't need all the special options for the link checker. Want to do that instead? |
|
ok, then I will remove readme from docs/source. Afterwards, if you could suggest what types of relevant content to add to docs/source, I'll implement those additions. |
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
Signed-off-by: Krishna babu <[email protected]>
|
The deploy docs job failed above, see https://github.com/opensearch-project/opensearch-py/actions/runs/9545324707/job/26305843780?pr=760. There's a link to this README that needs to be removed.
You should do this as part of this PR. There was a lot of stuff in the README, pick a minimal set of things that you think will be useful. |
Signed-off-by: Krishna babu <[email protected]>
Description
BUG FIX #538 , made modifications to the links.yml workflow file to address the issue with relative links in the README.md.
Here's a summary of the changes:
Added a new step before the link checking process. This step removes the symbolic link (soft link) of README.md in the docs/source directory. This prevents the link checker from incorrectly resolving relative links due to the presence of this soft copy.
In the arguments section of the lychee Link Checker, I've added an exclusion for the file reference to the docs/source/README.md. This exclusion is necessary because even though we've removed the soft link, other parts of the project or external references might still point to this location. By excluding it from the link check, we ensure that the checker doesn't attempt to validate any links that might reference this now-nonexistent soft link. This prevents potential false positives or errors that could arise from references to the removed soft link.
After the link checking is complete, I've added another step to recreate the soft link. This ensures that the repository structure remains intact and doesn't affect other workflows that might depend on the presence of this soft link.
Issues Resolved
Link checker will not fail for adding relative links in readme.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.